Adding support for for..of and friends#84
Merged
erikd merged 1 commit intoquintenkasteel:new-astfrom May 2, 2019
mumuki:feature-for-of-support
Merged
Adding support for for..of and friends#84erikd merged 1 commit intoquintenkasteel:new-astfrom mumuki:feature-for-of-support
erikd merged 1 commit intoquintenkasteel:new-astfrom
mumuki:feature-for-of-support
Conversation
Collaborator
|
Very nice! Thanks! |
Collaborator
|
Do you need this released to Hackage? |
Contributor
Author
There is no hurry but that would be nice! Than you for the fast response. |
Collaborator
|
New version published! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR adds support for the following ES6 constructs:
for (let x; ...;...)for (let x in ...)for (let x of ...)for (var x of ...)for (x of ...)Although these constructs are not listed in #71, I think this is part of the issue. I have added the three types of tests that are suggested there.
oftoken in a similar fashion toin. However, onlyinis a true binary-operator, but I think there will be no issues with that 🤷♂️for...ofcontrol structure in a similar fashion to the current for-loops, but perhaps the AST may require a refactor in the future to avoid the cross product of all thevar/let/in/offeatures 🤔I hope everything is fine 🙏
Thanks! 😄